Don't compare file handles to NULL

Alexandre Julliard julliard at winehq.org
Thu Mar 8 07:28:55 CST 2007


Francois Gouget <fgouget at free.fr> writes:

> These are not false positives. Any file handle that is not 
> INVALID_HANDLE_VALUE must be closed with CloseHandle(). So these checks 
> should be against INVALID_HANDLE_VALUE, not NULL. In fact they may 
> possibly be removed altogether.

Note that a valid file handle will never be NULL, so while these
checks are wrong in theory, in practice it makes no difference.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list