Stub for all raw input functions

Dmitry Timoshkov dmitry at codeweavers.com
Fri Mar 30 06:28:15 CDT 2007


"Kovács András" <andras at csevego.net> wrote:

> +LRESULT WINAPI DefRawInputProc( PRAWINPUT *paRawInput, INT nInput, UINT cbSizeHeader )
> +{
> +    FIXME("(paRawInput=%p, nInput=%d, cbSizeHeader=%d) stub!\n", *paRawInput, nInput, cbSizeHeader);
> +
> +    return S_OK;
> +}

Although MSDN documents that on success DefRawInputProc returns S_OK,
that's most likely a misguided documenters error: S_OK is an HRESULT
and an OLE error value, while it's user32 and return type is LRESULT.
So IMO simply returning 0 should be OK here.

> +BOOL WINAPI RegisterRawInputDevices( PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize )
> +{
> +    FIXME("(pRawInputDevices=%p, uiNumDevices=%d, cbSize=%d) stub!\n", pRawInputDevices, uiNumDevices, cbSize);
> +
> +    return TRUE;
> +}

Probably this stub should return FALSE.

> +UINT WINAPI GetRawInputBuffer( PRAWINPUT pData, PUINT pcbSize, UINT cbSizeHeader )
> +{
> +    FIXME("(pData=%p, pcbSize=%p, cbSizeHeader=%d) stub!\n", pData, pcbSize, cbSizeHeader);
> +
> +    return 0;
> +}

MSDN says that an error indicator is -1, not 0, same as for others raw
input APIs.

-- 
Dmitry. 




More information about the wine-devel mailing list