shell32: handle invalid cbSize in Shell_NotifyIcon[AW] (fixed, with testcase)

Alexandre Julliard julliard at winehq.org
Wed May 9 04:38:49 CDT 2007


Mikołaj Zalewski <mikolaj at zalewski.pl> writes:

>  As I've understood from wine-devel to catch exceptions in tests I
> need to write my own handler. My handler is more compilcated than in
> ntdll/tests/exception.c as I can't assume the next instruction after
> the invalid one will be a 'ret' but is simplier than wine
> __TRY/__EXCEPT as I don't try to filter exception but catch all of
> them (I hope this is not a problem with stack guard pages or something
> like that). I'm also not using siglongjump but longjmp to be able to
> compile it with msvcrt.

It won't work when not using msvcrt, and it's really too ugly. That
sort of thing might be acceptable in an exception test in ntdll, but
not in shell32 tests. Please find another way to write the test that
doesn't rely on deliberately triggering a crash.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list