rsaenh: add support for mandatory parameters to
mounir.idrassi at idrix.fr
Wed May 9 07:04:40 CDT 2007
The problem comes from the file cert.c in crypt32 dll (the real one, not
the one in tests): at line 1976, the value AT_SIGNATURE is hardcoded in
case for failure of CryptGetProvParam. Without my patch, this function
definitely fail and the hardcoded value is written. So, a more complete
patch would include also a correction to this file.
Question: can a patch include corrections to different dlls? I can
submit it now.
IDRIX - Cryptography and IT Security Experts
Alexandre Julliard wrote:
> Mounir IDRASSI <mounir.idrassi at idrix.fr> writes:
>> This patch adds support for mandatory parameters in
>> RSAENH_CPGetProvParam. It also adds tests for them.
>> The mandatory parameters are: PP_UNIQUE_CONTAINER, PP_PROVTYPE,
>> PP_KEYSPEC, PP_KEYSET_TYPE, PP_KEYSTORAGE.
> Thanks for resending, but unfortunately this breaks make test:
> ../../../tools/runtest -q -P wine -M crypt32.dll -T ../../.. -p crypt32_test.exe.so cert.c && touch cert.ok
> cert.c:1215: Test failed: Expected AT_SIGNATURE, got 3
> make: *** [cert.ok] Error 1
> I know you sent a patch for that test, but since it currently succeeds
> on Windows the change can't be right.
More information about the wine-devel