[PATCH] Uninstaller: Change hardcoded value for maximum subkey name length to a const.

Tom Spear speeddymon at gmail.com
Wed May 9 11:12:47 CDT 2007

On 5/8/07, Dan Hipschman <dsh at linux.ucla.edu> wrote:
> I'm not sure what version of C wine is strictly trying to conform to,
> but it's usually best to go with the lowest common denominator.  This is
> not C89.  The const keyword doesn't actually make the variable constant
> (I know it's not the greatest feature of C).  The array size won't be
> evaluated until runtime, so technically this is a variable length array
> which weren't added until C99.  You can make it C89 simply by using
> #define instead of declaring it as a variable.
Hi.  Thanks for the comment.  I looked thru resource.h in the same
directory, and see MAX_STRING_LEN is defined at 255.  Would using that
be acceptable, or should I add a new define, something like #define
MAX_SUBKEY_LEN 255 ?  If I should add a new define, should I add it to
resource.h or directly to main.c?



Check out this new 3D Instant Messenger called IMVU.  It's the best I
have seen yet!


More information about the wine-devel mailing list