check for This->clipper before unreferencing in dlls/ddraw/surface.c

Stefan Dösinger stefandoesinger at gmx.at
Sat May 12 11:24:55 CDT 2007


Am Samstag 12 Mai 2007 15:00 schrieb Vincent Fourmond:
> (IDirectDrawSurfaceImpl_SetClipper): fixes segfault at HMMIV startup.
> ---
>  ChangeLog            |    6 ++++++
>  dlls/ddraw/surface.c |    5 +++--
>  2 files changed, 9 insertions(+), 2 deletions(-)
Now that wined3d stores the clipper, the surface->clipper member should be 
removed and GetClipper and SetClipper should use wined3dsurface::getclipper 
and Setclipper(like setpalette and getpalette does). also you do not have to 
modify the ChangeLog file, git does that automatically when AJ commits the 
patch.

Also please stick to the formating of the rest of the file / function. Here 
you used tabs instead of spaces for indention.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20070512/46110d2d/attachment.pgp


More information about the wine-devel mailing list