wininet: Add support for SSPI authentication for HTTP.

Alexandre Julliard julliard at winehq.org
Tue May 15 11:37:29 CDT 2007


Robert Shearman <rob at codeweavers.com> writes:

> +        if (strncmpiW(pszAuthValue, szBasic, sizeof(szBasic)/sizeof(szBasic[0])-1))
> +        {

When using strncmp you need to also check that you reached the end of
the first string.

> +    /* compare against last character to be set to avoid a race */
> +    if (HTTP_Base64Dec['/'] != 63)
> +    {

This won't avoid the race, you'll still get garbage if two threads get
here at the same time.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list