[PATCH 4/8, try3] msi: automation:
mk144210 at bcm.edu
Wed May 16 11:19:01 CDT 2007
On Wed, 2007-05-16 at 17:23 +0200, Michael Stefaniuc wrote:
> Misha Koshelev wrote:
> > On Wed, 2007-05-16 at 15:33 +0200, Alexandre Julliard wrote:
> >> Misha Koshelev <mk144210 at bcm.edu> writes:
> >>> ---
> >>> dlls/msi/automation.c | 36 +++++++++++++++++++-
> >>> dlls/msi/msiserver.idl | 4 ++
> >>> dlls/msi/msiserver_dispids.h | 1 +
> >>> dlls/msi/tests/automation.c | 74 ++++++++++++++++++++----------------------
> >> This one fails make test for me:
> >> ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok
> >> automation.c:1944: Test failed: Installer_ProductInfo failed, hresult 0x00000000
> >> make: *** [automation.ok] Error 1
> > Hmm... works for me but let me try doing a make clean; make depend; make
> > on all of wine to make sure something somewhere else has not changed
> > that changed its behavior.
> Sometimes you even need to remove your .wine directory too. Not that the
> tests assume something is already present in the enviroment.
Alright, I am afraid I am stumped here. I simply cannot reproduce
Alexandre's error. I have done a ./configure --prefix=/usr; make clean;
make depend; make; sudo make install and removed my ~/.wine and
everything still works hunky dory with the patch (and of course I did a
git fetch; git rebase origin first).
If anyone else could try applying it to their git tree, doing a make and
sudo make install in dlls/msi, wineprefixcreate (because IDL defns have
to be updated in the fake DLLs in the ~/.wine directory), and then make
automation.ok in the dlls/msi/tests directory and let me know if it
works for them that would be great.
I've attached the patch to the current git head below. It is the same as
the one on the wine-devel list except I've set my emacs to use spaces
now instead of tabs (and diff -w shows no differences except the
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 9426 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20070516/9d86cab4/0001-msi-automation-Implement-Installer-ProductInfo-0001.bin
More information about the wine-devel