[PATCH 3/4] msi: automation: Generalize list implementation.

Stefan Dösinger stefan at codeweavers.com
Fri May 18 16:29:36 CDT 2007


Am Freitag 18 Mai 2007 23:17 schrieb Misha Koshelev:
> On Fri, 2007-05-18 at 20:15 +0200, Alexandre Julliard wrote:
> > Misha Koshelev <mk144210 at bcm.edu> writes:
> > >              if (wFlags & DISPATCH_PROPERTYGET) {
> > >                  V_VT(pVarResult) = VT_I4;
> > > -                V_I4(pVarResult) = data->iCount;
> > > +                V_I4(pVarResult) = data->ulCount;
> >
> > I committed this patch, but I can't resist pointing out that if you
> > had simply named the field "count" instead of using the (idiotic)
> > Hungarian notation, the code would be just as clear, and you wouldn't
> > need to rename it everywhere when making it unsigned...
>
> So is the general recommendation for wine that we not use Hungarian
> notation then?
Alexandre usually calls it Hungarian Line Noise, I guess that means "no".



More information about the wine-devel mailing list