RegDeleteTree [10]
Stefan Leichter
Stefan.Leichter at camline.com
Fri May 25 13:23:04 CDT 2007
Am Friday 25 May 2007 18:41 schrieb James Hawkins:
> On 5/25/07, Stefan Leichter <Stefan.Leichter at camline.com> wrote:
> > Am Friday 25 May 2007 00:48 schrieb Juan Lang:
> > > Hi Stefan,
> > >
> > > + /* Find how many subkeys there are */
> > >
> > > This comment is incorrect.
> > >
> > > You have also reintroduced tabs in this patch - please don't do that.
> > > --Juan
> >
> > ChangeLog
> > -------------
> > added implementation of RegDeleteTreeA/W
>
> + if (lpszSubKey) {
> + ret = RegDeleteKeyW(hKey, lpszSubKey);
> + } else {
> + while (TRUE) {
> + dwSize = dwMaxLen;
> + if (RegEnumValueW(hKey, 0, lpszName, &dwSize,
> + NULL, NULL, NULL, NULL)) break;
> +
> + ret = RegDeleteValueW(hKey, lpszName);
> + if (ret) goto cleanup;
> + }
> + }
>
> Please stick with the style of the rest of the file, e.g., opening
> braces on the next line. There is one short function that uses the
> style you're using, but we don't need to be adding even more variety
> to the style.
Ok,
i'm getting tired reworking the patch. Send your comment within the next 48
hours or keep the for yourself.
I will stop modifying the patch after the next revision. This is not a threat,
this is a promise.
Stefan
More information about the wine-devel
mailing list