GDI+: headers and one test

Francois Gouget fgouget at
Thu May 31 08:59:09 CDT 2007

On Tue, 29 May 2007, Evan Stade wrote:
> include/Gdiplus.h                |   10 +++++
> include/GdiplusEnums.h           |   39 ++++++++++++++++++
> include/GdiplusFlat.h            |   23 ++++++++++
> include/GdiplusGpStubs.h         |   10 +++++
> include/GdiplusInit.h            |   26 ++++++++++++
> include/GdiplusTypes.h           |    7 +++

All filenames in Wine should be lowercase.

--- /dev/null
+++ b/include/Gdiplus.h
+#ifndef __cplusplus

Why check for __cplusplus here? The PSDK contains no such check, at 
least in this file.

--- /dev/null
+++ b/include/GdiplusEnums.h

The standard format for Wine headers is __WINE_HEADERNAME_H, unless we 
need to keep the original macro name for compatibility with the PSDK. 
But here you're following neither conventions (the other headers would 
need to be rechecked but they seem to keep the PSDK names).

--- /dev/null
+++ b/include/GdiplusFlat.h
+GpStatus WINGDIPAPI GdipCreateFromHDC(HDC hdc, GpGraphics **graphics);
+GpStatus WINGDIPAPI GdipDeleteGraphics(GpGraphics *graphics);

Wine headers generally don't keep the parameter names in the headers as 
they are not needed.

--- /dev/null
+++ b/include/GdiplusTypes.h
+typedef enum {
+} Status;

Hmm, this is not the same as the PSDK. The PSDK only defines 'enum 
Status { ... }' which, in theory, should only allow one to use 'enum 
Status' and not 'Status'. Yet the PSDK headers seem to make use of 
'Status'. This might be different in C++ though... 
So on the whole it's probably ok to use a typedef. I just prefer to 
bring this up so others can chime in.

Francois Gouget <fgouget at>    
                           La terre est une bêta...

More information about the wine-devel mailing list