shell32: Use SHStrDupW in IShellFolder2::GetDetailsOf to allocate returned string

Vitaliy Margolen wine-devel at kievinfo.com
Fri Nov 2 08:05:36 CDT 2007


Thomas Weidenmueller wrote:
> Use SHStrDupW in IShellFolder2::GetDetailsOf to allocate the returned
> string. pOleStr in the STRRET structure has to be allocated using
> CoTaskMemAlloc(). SHStrDupW uses CoTaskMemAlloc() whereas StrDupW uses
> LocalAlloc().
> 
> - Thomas
> ------------------------------------------------------------------------
> 
> Index: recyclebin.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/shell32/recyclebin.c,v
> retrieving revision 1.5
> diff -u -r1.5 recyclebin.c
> --- recyclebin.c	11 Jun 2007 13:47:57 -0000	1.5
> +++ recyclebin.c	1 Nov 2007 21:58:30 -0000

Please diff it from the top of the source tree. The above should say 
dlls/shell32/recyclebin.c

Vitaliy.



More information about the wine-devel mailing list