[SPAM] Re: USER32: win16 applications should not see long filenames returned from dialog control (try 2)

Alexandre Julliard julliard at winehq.org
Tue Nov 6 07:10:20 CST 2007

Alex Villací­s Lasso <a_villacis at palosanto.com> writes:

> Sorry, but I have to object. According to the documentation in MSDN, 
> DlgDirSelectExA returns nonzero when the current selection is a 
> directory name, and zero when it is not. However, plain filenames do not 
> qualify as directory names, so DlgDirSelectExA won't return nonzero on 
> them either. I checked on wine's implementation just to be sure. So 
> checking ret will not tell apart a case of failure from a case of a 
> plain filename being returned. That is why I need to zero out the last 
> error and check against it after return.

That still won't work, because our implementation doesn't set last error
on failure. Maybe it should, but that will require some test cases.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list