advapi32: fix buffer overrun in tests/registry.c:wine_debugstr_wn(), try 3

Dan Kegel dank at kegel.com
Wed Nov 7 08:31:49 CST 2007


On 11/7/07, Alexandre Julliard <julliard at winehq.org> wrote:
> That function is really supposed to print n chars, not n-1.  The
> terminating null probably needs to be included in the length.

Hmm.  The function is only called on registry keys and values,
none of which are really nul terminated (and some vendors
use embedded nuls on purpose).
I think the unconditional nul termination check is a bug
introduced when the author forked
the function from the copy in libs/wine/debug.c.
Patch coming...



More information about the wine-devel mailing list