dlls/msi/string.c -- fix use of signed versus unsigned (RESEND)

Dan Kegel dank at kegel.com
Thu Nov 15 22:18:58 CST 2007


Gerald Pfeifer wrote:
> How do you propose to address the following?
>  string.c: In function 'msi_addstring':
>  string.c:208: warning: comparison between signed and unsigned

For starters:

diff --git a/configure.ac b/configure.ac
index 3d62f45..c97aa8e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1134,6 +1134,7 @@ then
   WINE_TRY_CFLAGS([-fno-strict-aliasing])
   WINE_TRY_CFLAGS([-Wdeclaration-after-statement])
   WINE_TRY_CFLAGS([-Wwrite-strings])
+  WINE_TRY_CFLAGS([-Wno-sign-compare])

   dnl Check for noisy string.h
   saved_CFLAGS="$CFLAGS"

Then, after we've fixed all the real bugs, maybe consider
going back and turning on the signed/unsigned comparison warning.



More information about the wine-devel mailing list