svchost: Added base implementation of svchost (1/27)

Roy Shea roy at cs.hmc.edu
Mon Nov 19 12:58:32 CST 2007


Hello Juan,

Thank you for the code review!  A quick clarification about HeapFree:

> Some judicious use of goto could reduce code for all your error paths.
> Remember that HeapFree of a NULL pointer is allowed.

The docs for HeapFree state "If this pointer is NULL, the behavior is
undefined."  So in practice the undefined behavior is benign?

Peace,
-Roy




More information about the wine-devel mailing list