widl [3/4]: Remove printf format strings that aren't really format strings.

Michael Stefaniuc mstefani at redhat.com
Thu Oct 18 13:15:22 CDT 2007

Dan Hipschman wrote:
> On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote:
>> Dan Hipschman wrote:
>>> This is just a minor cleanup patch.  Even if we're definitely sure a
>>> string doesn't contain any % signs, it's still better not to use it as a
>>> printf format string.
>> fputs() would be a faster alternative to that. Though i doubt that
>> matters in this case.
> You're right, I just use fputs so rarely that I sometimes forget it
> exists.  Feel free to change them, but like you said, it probably
> doesn't matter much here.
No, i don't like fputs(). It has the arguments the wrong way around
which is more confusing then using fprintf() (of course if it's not in
the hot path and performance critical).

Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart
Handelsregister: Amtsgericht Stuttgart HRB 153243
Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham,
                 Werner Knoblich

More information about the wine-devel mailing list