gdi32 (1/2): fix unchecked NULL ptr in BIDI_Reorder

Alexandre Julliard julliard at
Mon Oct 22 08:50:07 CDT 2007

Alexander Dorofeyev <alexd14 at> writes:

>  >> One problem is that it wasn't assured lpOutString isn't NULL, and NULL
>  >> was getting passed to this routine by GetCharacterPlacementW. so it was
>  >> crashing in memcpy. This patch creates a temporary buffer when
>  >> lpOutString is NULL and it is used for in-place modifications instead in
>  >> such case.

You shouldn't need to allocate a new buffer, the output modifications
should be skipped when no output string is requested.

Alexandre Julliard
julliard at

More information about the wine-devel mailing list