crypt32: Remove a test because of a Windows 2003 SP1 bug
msclrhd at googlemail.com
Thu Oct 25 15:29:01 CDT 2007
Juan Lang wrote:
> - /* Now check just the time */
> - flags = CERT_STORE_TIME_VALIDITY_FLAG;
> - parent = CertGetIssuerCertificateFromStore(store, child, NULL, &flags);
> - ok(parent != NULL, "CertGetIssuerCertificateFromStore failed: %08x\n",
> - GetLastError());
> - /* Oops: the child is not expired, so the time validity check actually
> - * succeeds, even though the signing cert is expired.
> + /* Checking time validity is not productive, because while most Windows
> + * versions return 0 (time valid) because the child is not expired,
> + * Windows 2003 SP1 returns that it is expired. Thus the range of
> + * possibilities is covered, and a test verifies nothing.
The test being removed is correct and valid. Removing it could lead to
a regression in Wine as this case is not being covered when this patch
While a 100% pass rate is ideal, on Windows 2003 SP1 that test *is*
failing due to a bug. However, this is the correct behaviour, and the
bug is detected by this test.
More information about the wine-devel