msi(1/3): Don't crash if rec is NULL
truiken at gmail.com
Fri Sep 14 15:43:33 CDT 2007
On 9/14/07, Jeremy White <jwhite at winehq.org> wrote:
> Your patches also cure the symptom, Juan; thanks.
> I agree with the concerns James expressed, though: I didn't feel that I
> understood the whole story. (Heck, I really have *no* clue what I'm
> talking about <grin>).
> However, the call to MSI_FormatMessageW is not an internal call, I think;
> it looks to me as though it's called as a direct result of an inbound
> call to MsiFormatRecordA():
> 0014:Call msi.MsiFormatRecordA(00000002,00000005,1000e768,7b7ea55c) ret=10003064
> (in http://bugs.winehq.org/attachment.cgi?id=8060 about 10-15 lines from bottom)
> So the question in my mind is:
> Can a record still be a legitimate record if MSI_RecordGetFieldCount returns 0?
> If the answer is yes, then I think the patches are correct.
I don't know off the top of my head, but tests should definitely be
added before a fix goes in.
More information about the wine-devel