widl [2/2]: Implement pointer descriptions for complex structures

Robert Shearman rob at codeweavers.com
Wed Sep 19 08:11:22 CDT 2007


Dan Hipschman wrote:
> On Tue, Sep 18, 2007 at 11:15:26PM +0100, Robert Shearman wrote:
>   
>>> Sorry, I missed your last three patches somehow.  My patch not only uses
>>> RPC_FC_POINTER instead of RPC_FC_LONG here, but it also implements the
>>> pointer description section for complex structures.
>>>       
>> Right, but I was really talking about the approach of passing a flag 
>> into write_member_types or passing the containing type in. I think it is 
>> slightly cleaner to do the former, but your patch works very well for 
>> the case I was trying to fix.
>>     
>
> Well, it's such a small section of code it probably doesn't matter much
> either way.  I tend to avoid boolean arguments because when you look at
> the call to the function and just see a bunch of TRUEs and FALSEs, it's
> hard to remember what they mean.

Sure, it doesn't really matter and your set of patches implements more 
functionality. I'm happy to drop my patches in favour of yours.

-- 
Rob Shearman




More information about the wine-devel mailing list