WineD3D patch submission

Roderick Colenbrander thunderbird2k at
Sat Sep 22 04:42:06 CDT 2007

> Hi all,
> A week or so ago I tried to get a game working in WINE (Titan Quest), 
> however it seems it really needs a proper DIB engine before it'll be 
> playable.
> Anyways, in my attempt to get it working I fixed up some issues w/ 
> "IWineD3DDeviceImpl_UpdateSurface.c" in dlls/wined3d, not entirely sure 
> how you guys do things around here so I thought i'd just post my changes 
> to the function in this mailing list and you can do with it what you 
> want.  (Note: it actually has a few different methods of doing one 
> thing, enclosed in macro blocks to toggle between them.  Technically the 
> first one should work (i think :\) once you guys properly implement 
> surface locking/unlocking, and it's 'simplest', but the last one is the 
> only one that actually works properly (using standard OpenGL calls).
> You'll probably have to clean up the code to meet your coding standards 
> / etc, maybe remove the custom byte size calculation of compressed 
> images, and some other things - but the functionality is there...  i 
> also fixed the existing code that didn't actually do what it was 
> supposed to, heh.
> Regards,
> Mitchell Wheeler


Could you submit a patch (the difference between the original file and your changes). That makes it easier to comment on. When it is good you need a patch file anyway as that's what added to wine's git.

Roderick Colenbrander

GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS.
Alle Infos und kostenlose Anmeldung:

More information about the wine-devel mailing list