shell32[1/2]: shlview: make the shell view control Unicode (fixesbuf #9767)

Dmitry Timoshkov dmitry at codeweavers.com
Wed Sep 26 01:33:38 CDT 2007


"Mikolaj Zalewski" <mikolaj at zalewski.pl> wrote:

>  When the control class is Unicode the listview will be sending 
> LVN_GETDISPINFOW instead of LVN_GETDISPINFOA and filenames with 
> charactes outside of the ACP will display properly.
>  I'm changing the type of a define from the include/ directory but 
> that's a define not present in the Windows SDK.

If that define doesn't present in SDK it shouldn't be in Wine either.

> --- a/include/shlobj.h
> +++ b/include/shlobj.h
> @@ -149,7 +149,7 @@ typedef struct
> */
> 
> typedef GUID SHELLVIEWID;
> -#define SV_CLASS_NAME   ("SHELLDLL_DefView")
> +#define SV_CLASS_NAME   ((const WCHAR[]){'S','H','E','L','L','D','L','L','_','D','e','f','V','i','e','w',0})

This construct is not portable. Please move this to appropriate source file,
and use 'static const WCHAR ...' syntax.

-- 
Dmitry.



More information about the wine-devel mailing list