[2/2] cabinet.dll -> FDICopy: Bug fixed

James Hawkins truiken at gmail.com
Tue Apr 1 12:08:49 CDT 2008

2008/4/1 Vitaly Perov <vitperov at etersoft.ru>:
> This is a bug fix for the FDICopy() function of cabinet.dll.
>  When you pass an empty cabinet file (It's correct cab-file, but it has no
>  files and folders inside) as a parameter, Wine detects that the file is
>  invalid.
>  In this case Windows return TRUE, but WINE return FALSE. So the installation
>  of certain software finishes with an error in WINE.
>  Changelog:
>      - Added a bug fix for cabinet.dll FDICopy function. Now it works correctly
>  with an empty cab-files.

+  if (!num_folders)
+    WARN("weird cabinet detect failure: This is an empty cabinet file \n");
+  /* if num_folders is 0, it's correct cab, but empty */

If there's a test for this case, and it is a valid case, then why did
you leave the WARN?

James Hawkins

More information about the wine-devel mailing list