[PATCH 14/15] wined3d: Add device->isInDraw checks in LoadLocation.

Alexander Dorofeyev alexd4 at inbox.lv
Mon Apr 7 01:30:20 CDT 2008

Oh, you are right. Must be fixed some other way then, I guess, maybe moving 
assignment to isInDraw lower or moving ActivateContext higher. From what I 
understood from Bioshock bug (http://bugs.winehq.org/show_bug.cgi?id=9973), 
moving ActivateContext in drawPrimitive produces bugs in other programs, right? 
Could you add to that bug a short description of what games etc needed to 
reproduce these problems?

Allan Tong wrote:
> On Sun, Apr 6, 2008 at 5:06 PM, Alexander Dorofeyev <alexd4 at inbox.lv> wrote:
>>  Prevents calling ActivateContext while holding gl lock, e.g. when
>> preloading texture in sampler().
> There may be a problem here with drawPrimitive, which calls
> LoadLocation before ActivateContext while having isInDraw=TRUE.  If
> the primary render target is an offscreen FBO surface, LoadLocation
> will follow the SFLAG_INTEXTURE path and it may end up making gl calls
> without a context in place.
>  - Allan

More information about the wine-devel mailing list