Several patches for D3DX

James Hawkins truiken at gmail.com
Fri Apr 11 18:27:53 CDT 2008


On Fri, Apr 11, 2008 at 6:20 PM, Luis Busquets
<luis.busquets at ilidium.com> wrote:
> Is there still any problem with each of the attached patches or are they
> going to be committed?
>

+WINAPI DWORD D3DXGetShaderVersion(CONST DWORD *pFunction)
+{
+    DWORD ver;
+    if (!pFunction)
+     {
+      return 0;
+      }
+    /* The first DWORD of the stream is the version Token */
+   ver=*pFunction;
+   return ver;
+}

I can't attest to any of the rest, but the style in this function is
horrendous.  Your spacing is all over the place.  Also, correctness of
this function aside, the function can be written so much simpler as:

WINAPI DWORD D3DXGetShaderVersion(CONST DWORD *pFunction)
{
    return (pFunction) ? *pFunction : 0;
}

-- 
James Hawkins



More information about the wine-devel mailing list