urlmon: add stub for CoInternetSetFeatureEnabled

Hin-Tak Leung hintak_leung at yahoo.co.uk
Sun Apr 13 08:37:48 CDT 2008

Dmitry Timoshkov wrote:
> "Louis. Lenders" <xerox_xerox2000 at yahoo.co.uk> wrote:
>> +HRESULT WINAPI  CoInternetSetFeatureEnabled(INTERNETFEATURELIST Feature, DWORD flags, BOOL fEnable)
>> +{
>> +    FIXME("%p, 0x%08x, %x, stub\n", &Feature, flags, fEnable);
>> +    return E_NOTIMPL;
>> +}
>> diff --git a/dlls/urlmon/urlmon.spec b/dlls/urlmon/urlmon.spec
>> index 1fa2f94..e89e049 100644
>> --- a/dlls/urlmon/urlmon.spec
>> +++ b/dlls/urlmon/urlmon.spec
>> @@ -19,6 +19,7 @@
>> @ stdcall CoInternetGetSession(long ptr long)
>> @ stdcall CoInternetParseUrl(wstr long long wstr long ptr long)
>> @ stdcall CoInternetQueryInfo(ptr long long ptr long ptr long)
>> +@ stdcall CoInternetSetFeatureEnabled(ptr long long)
> The first parameter of CoInternetSetFeatureEnabled is not a pointer even
> if you pretend it is in the FIXME. Also Please use consistent spacing and
> naming of variables (preferring 1 space and no hungarian/upper cased names).

oh, I just made the same comment (http://bugs.winehq.org/show_bug.cgi?id=12406#c7 ):

I had a look at this - INTERNETFEATURELIST is a enum, not a long pointer;
oh, and the stub code itself should go into internet.c (where similiarly
named/used functions resides), instead of urlmon_main.c .

Other than these, the patch took the doc explorer further, so
I think basically just needs a 'FIXME("Not implemented\n");' to be sent off...

More information about the wine-devel mailing list