RFC: Fix for IWineMsiRemotePackage::FormatRecord

James Hawkins truiken at gmail.com
Tue Apr 15 15:12:32 CDT 2008

On Tue, Apr 15, 2008 at 12:40 PM, Robert Shearman <rob at codeweavers.com> wrote:
> Hi,
>  Currently, the [out] value parameter for
> IWineMsiRemotePackage::FormatRecord doesn't have a level of indirection
> associated with it and so I would be very surprised if the typelib
> marshaller actually does the right thing in this case. Compiling with MIDL
> and with a future update to widl causes an error for this parameter. I'm
> proposing the attached patch to fix things, but I'm not able to test that
> this works correctly.

> Remove the redundant size parameter and simplify the client code such that the remote function is only called once, with the value being automatically allocated. Add corresponding code on the server side to automatically allocate said value.

Yea, this is good.  I remember that I had a problem with this when I
wrote it, but I wasn't sure of the right way to go.

James Hawkins

More information about the wine-devel mailing list