gdi32: Make the bitmap test pass under Windows 2000. Take 2
paul.vriens.wine at gmail.com
Wed Apr 23 01:08:55 CDT 2008
Dmitry Timoshkov wrote:
> "Paul Vriens" <paul.vriens.wine at gmail.com> wrote:
>>>> It's that last piece: "assuming there's enough memory left".
>>> That's a valid assumption I'd guess, and a lot of tests already rely
>>> on this: every thing which indirectly or directly allocates memory,
>>> creates windows, objects, processes, etc.
>> But the test doesn't cater for that.
>> If I run the test with several heights on my win2k box the maximum I
>> can have is:
>> CreateBitmap(0x7fff,0x2e63, ...
>> before it fails with ERROR_NOT_ENOUGH_MEMORY.
>> This of course differs on every run. My point is that
>> ERROR_NOT_ENOUGH_MEMORY is totally valid and should be catered for in
>> the test otherwise we would still have failures for this test.
> I don't think it's a good idea to pollute every test that could fail
> due to insufficient memory with fake error handling.
The title of the patch says "Make the bitmap test pass under Windows 2000".
Introducing the test as you did doesn't do that as in some cases it will fail.
But we can spent hours on this. Let's go on and see if AJ will accept the patch.
More information about the wine-devel