cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."

Reece Dunn msclrhd at
Sat Apr 26 01:03:53 CDT 2008

2008/4/26 James Hawkins <jhawkins at>:
> Hi,
>  The test was incorrect and failed on all platforms.  Vitaly, please
>  ask someone to test your patches on a real windows system in the
>  future if you don't have access to one.

Wouldn't it be better to actually fix the test case than revert it all together?

Just simply change line 630:

-    ok(ret, "Expected FDICopy to succeed\n");
+    ok(!ret, "Expected FDICopy to fail\n");

and remove the todo_wine. Adding a GetLastError check would be good as well.

- Reece

More information about the wine-devel mailing list