rpcrt4: [1/2] Improve stub for I_RpcBindingInqTransportType, with test

Detlef Riekenberg wine.dev at web.de
Sun Aug 10 17:13:33 CDT 2008


On So, 2008-08-10 at 12:21 +0900, Dmitry Timoshkov wrote:

> > +  /* NT: RPC_S_NO_CONTEXT_AVAILABLE, 9x: RPC_S_NO_CALL_ACTIVE */
> > +  if (!Binding) return RPC_S_NO_CONTEXT_AVAILABLE;

> According to your test this should be
> if (!Binding || !Type) return RPC_S_NO_CONTEXT_AVAILABLE;

No, your asumption does not match the test.
My test show, that Windows does not care about Type, when Binding is
NULL:
=> Binding must be checked first and *Type is not touched.

For your code above, the test must create and use a valid binding with
"Type == NULL".

> Also the comment doesn't belong here, it's ok to have in the test
> though.
OK.


-- 
 
By by ... Detlef





More information about the wine-devel mailing list