shlwapi: add some more tests for UrlUnEscape

Michael Karcher wine at mkarcher.dialup.fu-berlin.de
Mon Aug 18 13:31:28 CDT 2008


Am Montag, den 18.08.2008, 08:46 +0000 schrieb Louis. Lenders:
> hi, tests show that UrlUnEscape still converts the url-string if the
> bufferpointer is set to NULL, and the 
> URL_UNESCAPE_INPLACE is set. Test passes fine with native shlwapi, and
> in wine after applying the previous sent patch :
> http://www.winehq.org/pipermail/wine-patches/attachments/20080814/d5feb31b/attachment.txt

Please resend the patch including the testcase, instead of sending a
testcase alone. This puts test & fix into the same entry in git history,
so that a later review of the changes is eased by having the appropriate
testcase directly at hand. Patches including testcases also have a
higher chance of getting committed.

Regards,
  Michael Karcher





More information about the wine-devel mailing list