user32: fix error setting in FindWindow (try 2)

[Louis. Lenders]

----- Original Message ----
From: Alexandre Julliard <julliard at winehq.org>
To: Louis. Lenders <xerox_xerox2000 at yahoo.co.uk>
Cc: wine-devel at winehq.org
Sent: Friday, 22 August, 2008 4:54:49 AM
Subject: Re: user32: fix error setting in FindWindow (try 2)

"Louis. Lenders" <xerox_xerox2000 at yahoo.co.uk> writes:

> diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c
> index 1964e88..246347f 100644
> --- a/dlls/user32/tests/win.c
> +++ b/dlls/user32/tests/win.c
> @@ -4789,14 +4789,20 @@ static void test_hwnd_message(void)
>      SetLastError(0xdeadbeef);
>      found = FindWindowExA( GetDesktopWindow(), 0, 0, "message window" );
>      ok( found == 0, "found message window %p/%p\n", found, hwnd );
> -    todo_wine
> -        ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError());
> +    ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError());

>Have you tried your test on Windows?  According to the test results
>there isn't any Windows version that sets last error here.

If you're talking about the test above, that was a test written by someone else, i think it was committed on wednesday or so. I only take out the "todo_wine" there; 
i assumed that test passed on windows, as the patch was committed, but i now see on the test results page that it doesn't. 

I did run the test on windows yesterday ,  the whole console got spammed with lots of messages, and i guess i  overlooked something then ( i now see on the testpage that the failing test appears in the first lines of the spam, i only overlooked the last part in the console as i expected an eventually failing test there) 

As FindWindowEx apparently doesn't set an error, I'll have to recheck what FindWindow does on windows

Send instant messages to your online friends http://uk.messenger.yahoo.com 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.winehq.org/pipermail/wine-devel/attachments/20080822/1e691343/attachment.htm