Spore patch to fix UI and Part descriptions

Stefan Dösinger stefan at codeweavers.com
Fri Aug 22 10:04:35 CDT 2008


> +    rect.right = 0;
> +    rect.top   = NULL;
> +    rect.left  = NULL;
> +    rect.bottom= 0;

NULL is (void *) 0, so this test is the same as the one above, except that the compiler may warn about an implicit cast from pointer to integer. Otherwise, this goes into the right direction.


> -----Original Message-----
> From: wine-patches-bounces at winehq.org [mailto:wine-patches-
> bounces at winehq.org] On Behalf Of Andrew Fenn
> Sent: Friday, August 22, 2008 2:52 AM
> To: H. Verbeet; Stefan Dösinger
> Cc: wine-patches at winehq.org
> Subject: Re: Spore patch to fix UI and Part descriptions
> 
> I made a new patch this time including a test.
> 
> I put in some extra checking in SetScissorRect making sure that if rect
> was null or it was an invalid rectangle that it was returned as invalid
> as it should be.
> 
> I'm not able to do a test on windows so if anyone does one please let
> me know if there are any problems. Also please tell me if you spot any
> problems with this patch.
> 
> Thanks,
> Andrew




More information about the wine-devel mailing list