Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

Ken Thomases ken at
Mon Aug 25 13:11:34 CDT 2008

On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote:

> "Dan Kegel" <dank at> writes:
>> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard  
>> <julliard at> wrote:
>>> patchwatcher should watch for replies on wine-devel, and
>>> link the reply to the patch
>> Yes.   The other similar patchwatching systems I found do this,
>> and ours should, too.
>>> and mark the patch as needing further action on the submitter's  
>>> part.
>> Even if the message says "Great job!"?
> Sure, that's not the usual case. In most cases when a patch gets a  
> reply
> it's because it will need changes. There could of course be a way  
> for a
> submitter to mark the patch as still valid, but the first action  
> should
> be to take the patch off the list of committable patches.

Perhaps replies meant to approve of a patch could include a special  
textual directive to indicate that patchwatcher shouldn't block the  
patch.  Something like:

#patchwatcher approve

Such a directive would only be recognized if it's alone on a line.


More information about the wine-devel mailing list