Add TRACEs to NtCreateFile returns (second try)

[Markus Hitter]

Am 25.08.2008 um 21:39 schrieb James Hawkins:

> As the code stands now, regardless of your patch, the check for  
> NULL attr on line 154 of dlls/kernel32/file.c will never be hit  
> because we will crash in the TRACE on line 148 of dlls/kernel32/ 
> file.c.

Now I got it. You aren't talking about the TRACE() you cited, but a  
different one. Thanks for the line numbers, applied to dlls/ntdll/ 
file.c they make sense.

So, why not fix this? Please push the patch trough Wine's patch  
accepting mechanism yourself, I'm currently somewhat sick of it.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-Fix-a-possible-NULL-dereferencing.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20080826/daef49e6/attachment.txt 
-------------- next part --------------



> My comment still stands that the added TRACE is absolutely  
> superfluous.

Makes 2 pro, 1 neutral. Do whatever you want with it.


MarKus

- - - - - - - - - - - - - - - - - - -
Dipl. Ing. Markus Hitter
http://www.jump-ing.de/