ntdll/file.c: Allow to TRACE NtCreateFile return

Markus Hitter mah at jump-ing.de
Wed Aug 27 04:28:49 CDT 2008


Am 27.08.2008 um 10:14 schrieb Dmitry Timoshkov:

> "Markus Hitter" <mah at jump-ing.de> wrote:
>
>> Providing the file handle allows to map
>> read/write requests to the corresponding file name.
>
> As pointed out by Alexander, you can use an appropriate debug
> channel for that, +relay or +server. There is no need to pollute
> the source with additional traces.

If you think this way, you should get rid of all the TRACE()s in this  
source file.

For me, it makes a difference, wether I can focus on file operations  
or if I have to wade through gigabyte-sized (no joke) log files. To  
give you an example how it looks:

trace:ntdll:NtCreateFile handle=0x339750 access=80000000 name=L"\\??\ 
\C:\\Programme\\Dassault Systemes\\B16\\intel_a\\EnvName.txt"  
objattr=00000042 root=(nil) sec=(nil) io=0x339724 alloc_size=(nil)
attr=00000080 sharing=00000003 disp=1 options=00000050 ea=(nil). 
0x00000000
trace:ntdll:NtCreateFile returning handle 0x144
trace:ntdll:NtReadFile (0x144,(nil),(nil),(nil), 
0x3397c4,0xd93888,0x00001000,(nil),(nil)),partial stub!
trace:ntdll:NtReadFile = SUCCESS (17)

All but one of these lines are already there.


As there's nothing left to simplify, I take this patch back.


MarKus

- - - - - - - - - - - - - - - - - - -
Dipl. Ing. Markus Hitter
http://www.jump-ing.de/







More information about the wine-devel mailing list