improvement to patchwatcher

[Zachary Goldberg]

On Wed, Aug 27, 2008 at 11:59 AM, Dan Kegel <dank at kegel.com> wrote:
> On Wed, Aug 27, 2008 at 8:54 AM, Zachary Goldberg <zgold550 at gmail.com>
>> to simply mark any individual patch as 'already
>> applied to the tree' vs not applied isn't so difficult.
>
> Patches gratefully accepted.  The file to change is
> http://code.google.com/p/winezeug/source/browse/trunk/patchwatcher/dashboard.pl
> - Dan
>



Attached is a first attempt at a patch.  On every cycle of the
continuously running patchwatcher I call a new function which attempts
to re-apply all patches it finds.  Perhaps there is a smarter way to
do this than re-applying all patches but i can't think of anything
simple - the reason being we don't know how far back to check and see
if Alexandre has committed.  Anyway, we store the output of the patch
command in a new file.  The dashboard then checks the patch output to
determine if the patch failed because 'patch' thinks the patch was
already applied.

I am sure there will need do be some churn on it before its
acceptable, and I know this because I haven't tested it.  I don't have
a mailbox on my local machine subscribed to wine patches is problem
one, although that could be fixed i guess.  The second, harder to fix,
issue is that running the wine test suite crashes my computer (nvidia
driver bug I imagine).  I don't have a secondary machine which I could
setup mesa drivers and the patchwatcher.

Thoughts, Dan?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patchwatcherdiff.patch
Type: application/octet-stream
Size: 2979 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080827/100111d5/attachment.obj