Recent msi/package tests failures

Paul Vriens paul.vriens.wine at gmail.com
Thu Aug 28 14:06:05 CDT 2008


James Hawkins wrote:
> On Wed, Aug 27, 2008 at 2:18 PM, Paul Vriens <paul.vriens.wine at gmail.com> wrote:
>> James Hawkins wrote:
>>> On Wed, Aug 27, 2008 at 11:40 AM, Adam Petaccia <adam at tpetaccia.com>
>>> wrote:
>>>> On Wed, 2008-08-27 at 10:26 +0200, Paul Vriens wrote:
>>>>> Hi,
>>>>>
>>>>> I was looking into the recent test failures for the msi/package tests on
>>>>> my
>>>>> WinXP box.
>>>>>
>>>>> The reason for most of them was a stray MSITEST package that couldn't be
>>>>> removed
>>>>> via the 'Add/Remove Programs' (had to remove stuff from the registry).
>>>>>
>>>>> Any one else seeing this? (Adam Petaccia's XP box has the same issue I
>>>>> guess).
>>>>>
>>>> I can provide any details you need about the XP box, the first thing I
>>>> can think of is that the user running the tests is an administrator.
>>>>
>>> That's not why the tests are failing.  The install tests are timing
>>> out, and if the winetest executable kills the child process that it
>>> believes is 'hung', then you're killing the installer process midway
>>> through an install and thus leaving the system in a broken state.
>>>
>> So were back to fixing the timeouts.
>>
>> I double checked again and can't see any logging enabled (checked the
>> registry keys your provided).
>>
> 
> Of course; there are tons of tests.  The timeout needs to be extended,
> at least for install.c.
> 
I did all kinds of things to try and speed the tests up, to no avail.

The following patch however seems to help:

diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c
index 40fabf8..5c7c10c 100644
--- a/dlls/msi/tests/install.c
+++ b/dlls/msi/tests/install.c
@@ -5415,6 +5415,9 @@ START_TEST(install)

      get_program_files_dir(PROG_FILES_DIR, COMMON_FILES_DIR);

+    /* Disable logging */
+    MsiEnableLogA(INSTALLLOGMODE_ACTIONSTART, NULL,INSTALLLOGATTRIBUTES_APPEND);
+
      test_MsiInstallProduct();
      test_MsiSetComponentState();
      test_packagecoltypes();

Even when I now remove that MsiEnableLogA call, it's still within the timeout 
limit!!

Worthwhile adding to the test?

-- 
Cheers,

Paul.



More information about the wine-devel mailing list