[4/5] wined3d: Use a bitmask to store which bool and int constants are set.

Henri Verbeet hverbeet at gmail.com
Wed Dec 3 02:53:07 CST 2008


2008/12/3 Juan Lang <juan.lang at gmail.com>:
>> Why is this a good thing - this just artificially caps your constants at
>> 32. If I remember correctly I had to change shaders to do the exact
>> opposite change, because newer versions introduced more than 32 constants.
>
> I agree with you, this is a questionable change.  The benefit in
> reduced data results in a gain of code size and runtime cost.
> --Juan
>
Perhaps setting constants becomes slightly more expensive this way,
but I'm not convinced it's very significant. The more performance
critical code that applies the constants becomes significantly cheaper
though.



More information about the wine-devel mailing list