[resend] gdi32/tests: Add a test for GdiGetCodePage().

Paul Vriens paul.vriens.wine at gmail.com
Sun Dec 14 06:34:35 CST 2008


ByeongSik Jeon wrote:
> http://bugs.winehq.org/show_bug.cgi?id=16325
> ---
>  dlls/gdi32/tests/Makefile.in |    2 +-
>  dlls/gdi32/tests/font.c      |  152 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 153 insertions(+), 1 deletions(-)
> 
> 
> ------------------------------------------------------------------------
> 
> 
Hi,

Could you turn the skip in this piece of code:

+    if (!pGdiGetCodePage)
+    {
+        skip("GdiGetCodePage not available on this platform\n");
+        return;
+    }

into a win_skip? That way we fail if the function is not available in Wine.

Another thing I'm not sure about though is that in the for() loop you 
don't do a DeleteObject( hfont ). Is that only needed at the end?

-- 
Cheers,

Paul.



More information about the wine-devel mailing list