user32: Sign-compare warnings fix (Try 2)

[James Mckenzie]

-----Original Message-----
>From: Alexandre Julliard <julliard at winehq.org>
>Sent: Dec 15, 2008 5:25 AM
>To: Andrew Talbot <andrew.talbot at talbotville.com>
>Cc: wine-devel at winehq.org
>Subject: Re: user32: Sign-compare warnings fix (Try 2)
>
>Andrew Talbot <andrew.talbot at talbotville.com> writes:
>
>> diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c
>> index 9dd9083..4ea1959 100644
>> --- a/dlls/user32/dialog.c
>> +++ b/dlls/user32/dialog.c
>> @@ -84,9 +84,9 @@ typedef struct
>>    /* Radio button group */
>>  typedef struct
>>  {
>> -    UINT firstID;
>> -    UINT lastID;
>> -    UINT checkID;
>> +    INT firstID;
>> +    INT lastID;
>> +    INT checkID;
>>  } RADIOGROUP;
>
>This change would need a test case.
>
Alexandre/Andrew:

I don't think this change is necessary, unless there is checking against a -1 somewhere in the code.  Also, I would like to see an array of 32K or so radio buttons somewhere in Windows code.

James McKenzie