Unused vtables and debug channels

Christian Costa titan.costa at wanadoo.fr
Mon Dec 15 16:35:47 CST 2008


I Agree.

There was also this can of cleanup in d3dxof and direct music dlls 
whereas there are not complete.
Some code are put in place as placeholder for future developments in one 
hand and there is some clean-up to remove them in the other.
I don't see the point.

Christian

James Hawkins a écrit :
> On Mon, Dec 15, 2008 at 1:41 PM, Andrew Talbot
> <andrew.talbot at talbotville.com> wrote:
>   
>> It appears that the following vtables and Wine debug channels are not being used, so I am considering removing them. Please let me know, therefore, if you have plans for any of them and want them kept.
>>
>>
>>     
>
> Why would you remove any of them?  That's like removing stub functions
> because we don't know if they're ever called.
>
>
> Yes to keeping the following two, and I'm pretty sure you're going to
> get the same response for the entire list.  They're stubbed out
> because they need to be implemented.  The APIs that provide access to
> the objects are stubs as well, which is why you're saying they're not
> being used.
>
>   
>> AssemblyCacheItemVtbl                   fusion/asmcache.c
>> AssemblyEnumVtbl                        fusion/asmcache.c
>>     
>
>
>   





More information about the wine-devel mailing list