[RFC] wined3d: Avoid triggering OPENGL errors when setting point size

Henri Verbeet hverbeet at gmail.com
Mon Dec 22 18:49:03 CST 2008


2008/12/23 Vincent Pelletier <plr.vincent at gmail.com>:
> If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render state is
> set to an invalid size, glPointSize will fail.
> This happens in "Black & White 2", causing log/stderr to be flooded with
> opengl errors.
>
> I'm not sure if this should be fixed here, or when setting state value.
> Also, maybe it should be avoided to double-check against opengl bounds when
> WINED3DRS_POINTSCALEENABLE is true.
>
I think it makes more sense to clamp the value to be within the
limits, rather than using whatever was used last.



More information about the wine-devel mailing list