d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

Detlef Riekenberg wine.dev at web.de
Tue Dec 23 08:22:14 CST 2008

On Di, 2008-12-23 at 14:24 +0100, Stefan Dösinger wrote:
> I'm only afraid of this hypothetical scenario:
> 1) We remove a test because it breaks on $NONSTANDARDWINDRV

We disable the test with:
    if (0) {
        /* that crash on $NONSTANDARDWINDRV */
        <full test here>

> 3) Some future patch changes this behavior
> 4) The test doesn't warn us because it was removed

Of course, the disabled test does not protect us from the scenario
but the test is still available for documentation.

> IMHO it is better to use broken() wherever possible, although with a crash that is hard to do.

using broken() on a crashing test will not prevent the crash

By by ... Detlef

More information about the wine-devel mailing list