[PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

Nick Burns adger44 at hotmail.com
Tue Dec 23 13:11:08 CST 2008

Thanks for reviewing my patch (it sure makes the SHOGO menu much nicer)
BTW do you know if I need to resubmit my other SHOGO patch ([PATCH] Fix ddraw surface version setting)?

Concerning negative pixelzoom and drawpixels on R500
Please file a radar on that (and email the mac-opengl mailing list)

 - Nick

> From: stefan at codeweavers.com
> To: wine-devel at winehq.org
> Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)
> Date: Tue, 23 Dec 2008 13:30:40 +0100
> This patch looks good.
> There's one last thing we should check: It seems that this is the only code
> that uses GL_PACK_ROW_LENGTH and friends, so the backup and restore is
> probably not needed. I think for now it is better to add it because I
> suspect the code in surface_download_data most likely depends on the default
> settings without properly controlling them.
> There's some related driver bug on OSX too(no radar filed yet,
> unfortunately). Using a PBO for glDrawPixels with a negative pixelzoom(wine
> uses -1 for y) breaks at least on my radeon X1600 with MacOS 10.5.5. I
> haven't yet tested it with 10.5.6, but if it is still broken there I have to
> remember to file a bug. It is sort of a follow-up bug to a bug fixed in
> 10.5.5; Before that glPixelZoom and PixelPos were completely ignored with
> PBOs.
> This bug was on my todo list for a long time by the way. I wanted to fix it,
> got distracted and forgot again :-/

More information about the wine-devel mailing list