oledlg: Implement OleUIAddVerbMenuA/W functions [resend]

Austin English austinenglish at gmail.com
Wed Dec 24 11:29:00 CST 2008


On Wed, Dec 24, 2008 at 7:36 AM, Vitaly Lipatov <lav at etersoft.ru> wrote:
> В сообщении от 24 декабря 2008 Вы написали:
>> On Wed, Dec 24, 2008 at 5:49 AM, Vitaly Lipatov <lav at etersoft.ru> wrote:
>> > Hello,
>> >
>> > Can anyone comment what bad with my
>> > OleUIAddVerbMenuA/W implementation.
>> >
>> > I know no one is interested in this function at your side, but it is
>> > really used function for more than one year.
>> >
>> > В сообщении от 20 декабря 2008 Vitaly Lipatov написал(a):
>> >> Real implementation of the OleUIAddVerbMenu function.
>> >
>> > --
>> > Vitaly Lipatov, ALT Linux Team
>> > Russia, Saint-Petersburg, www.etersoft.ru
>>
>> Can you add a testcase for these functions?
> I know it is common question about testcase, but I think it does not means
> with this functions.
> Note, I do not fix some functions, I have implemented from scratch it instead
> stub.
> And my better test case is a popular account application used this functions.
>
>
> --
> Vitaly Lipatov, ALT Linux Team
> Russia, Saint-Petersburg, www.etersoft.ru
>

I'm not saying your patch is wrong by any means. Testcases serve as
documentation of the Win32 API, and also help prevent regressions in
those functions.

-- 
-Austin


More information about the wine-devel mailing list