wined3d: Do not treat oversized textures as failure

Henri Verbeet hverbeet at gmail.com
Sun Dec 28 09:40:48 CST 2008


2008/12/28 Vincent Pelletier <plr.vincent at gmail.com>:
> Le Sunday 28 December 2008 16:21:25 Vincent Pelletier, vous avez écrit :
>> Attached patch is enough to cure the failure in "Operation Flashpoint" when
>> its menu is displayed on my little i945GM card.
>
> It also fixes mipmap test in d3d9/tests/visual.c, removing the need for a
> patch I sent earlier which purpose was to skip mipmap test when texture
> allocation fails.
>
The test should probably check the device caps before trying to create
the texture.

> Some other notes on IWineD3DDeviceImpl_CreateTexture:
> If oversize is treated as an error and return value is changed to some error
> code, there seems to be a memory leak: it crashes happens after a rouhly
> constant number of frames are rendered, but this time hr has a non-null value
> in IWineD3DDeviceImpl_CreateTexture.
>
CreateTexture() and similar calls leak on error, yeah. This is
something that needs to be fixed.


More information about the wine-devel mailing list