Is there a Git Repositories for Unaccept Patches or (work in Progress)?
jjmckenzie51 at sprintpcs.com
Sun Feb 10 22:18:50 CST 2008
Steven Edwards wrote:
> On Feb 10, 2008 1:55 PM, Dan Kegel <dank at kegel.com> wrote:
>> Joeseph wrote:
>>> Is there a Git Repositories for Unaccept Patches or (work in Progress)?
>> Not really, but people often attach patches to bugzilla
>> entries if they're not quite good enough to submit.
>> And if anybody wants to start such a git repository,
>> more power to them.
> I've got a local git repo setup where I have the winequartzdrv from
> darwine sitting and I have been trying to bring up to date but never
> have time to mess with it. It would be cool if we had a repo for
> unacceptable patches that we could write to and maintain branches on
> for projects like this because with others working on it it might one
> day evolve in to the shape of something he would accept.
I would like to 'chime' in here. If you have it local and it is not
complete, why submit to the main program flow. Create a bug and put it
there. Simple and it keeps the code tree "clean". This allows others
to become aware of what you are up to and can increase collaboration.
Otherwise, your work becomes 'lost' and will never be complete. I would
NEVER submit anything to the tree that is not complete and ready for
review by Alexandre. I have been a victim of the dreaded drop, but that
is not because the code I submitted was incomplete, but parts of it have
become irrelivant because of changes to the tree. So, I've had to back
up and redo the work and then collaborate with the original submitter
and have a peer review and then submit. Hopefully this will be
applicable to your project.
Again, to summarize, if your code is not ready for Alexandre's review,
open a bug, put your changes there, let the development list know and
kick back and see what happens. If you need help, submit your code and
then let others help. Don't expect things to happen overnight,
sometimes it can take weeks or months.
Also, I am very interested in your work on winequartz, please let me
know what the bug number is.
More information about the wine-devel