d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9, try 2]

Dmitry Timoshkov dmitry at codeweavers.com
Sun Feb 24 07:35:43 CST 2008

<tony.wasserka at freenet.de> wrote:

> Replaced the S_OKs with D3D_OKs, moved the QueryInterface TRACE out of the if condition
> and replaced object by *object.

You have fixed object to *object, what about other places with
a similar problem? Also, the stubs have to use FIXME not TRACE,
and if you do nothing with a passed in parameter, don't assign
it to an internal variable. There is no need to cast NULL either.
If you allocate memory on object creation, you must free it on
object destruction. There is no need to initialize 'object' to
NULL if on the next line you are doing an attempt to allocate it.
What's the point of adding all those includes to d3dx9_36_private.h
if you are not using them?


More information about the wine-devel mailing list